Skip to content

Fix gh actions failures #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 9, 2025
Merged

Fix gh actions failures #2016

merged 5 commits into from
Jan 9, 2025

Conversation

@stephprince
Copy link
Contributor

@stephprince stephprince commented Jan 9, 2025 •
edited
Loading

Motivation

This PR will fix a couple of our current workflow failures. These changes were originally included in #2015, but I have moved into a separate PR here so that we can merge into dev before the 3.0 release.

These changes will:

  • Fix the daily run_all_tests.yml workflows that are failing due to some tox environment configuration errors introduced in Remove python 3.8 support and add python 3.13 support #2007
  • Fix the python 3.13 gallery test failures due to an import from a deprecated scipy dataset
  • Fix the sphinx link check workflows failing due to an update to the hdmf-zarr docs

TODO

  • manually trigger run_all_tests.yml workflow to check that it runs successfully

How to test the behavior?

Run the run_all_tests.yml workflow

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff check . && codespell from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@stephprince stephprince mentioned this pull request Jan 9, 2025
Merged
8 tasks
@stephprince stephprince marked this pull request as ready for review January 9, 2025 19:05
@stephprince stephprince requested a review from rly January 9, 2025 19:05
@stephprince stephprince merged commit b84b04a into dev Jan 9, 2025
70 checks passed
@stephprince stephprince deleted the fix-gh-actions-failures branch January 9, 2025 19:48
@codecov
Copy link

codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.69%. Comparing base (80fc386) to head (2ee7798).
Report is 40 commits behind head on dev.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #2016   +/-   ##
=======================================
  Coverage   91.69%   91.69%           
=======================================
  Files          27       27           
  Lines        2708     2708           
  Branches      707      707           
=======================================
  Hits         2483     2483           
  Misses        149      149           
  Partials       76       76
Flag Coverage Δ
integration 72.60% <ø> (ø)
unit 83.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rly rly rly approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stephprince @rly